test: refactor mock api server to fail on error #141
Conversation
m90
force-pushed
the
fr/test-mock-api
branch
2 times, most recently
from
af9b6ef to
1c85de4
Compare
m90
force-pushed
the
fr/test-mock-api
branch
7 times, most recently
from
562f56e to
f40e6e5
Compare
| @@ -17,4 +17,4 @@ DB_PASS=change-this-sqlpassword | |||
| WIKIBASE_PINGBACK=false | |||
| # wikibase.svc is the internal docker hostname, change this value to the public hostname | |||
| WIKIBASE_HOST=wikibase.svc | |||
| WIKIBASE_PORT=80 | |||
There was a problem hiding this comment.
Not sure if this has some background, but I cannot bind to port 80 locally using docker compose unless I elevate priviliges.
There was a problem hiding this comment.
I think there is no reason to keep this like it is; I guess it was just picked at some point to look closest to prod. After all these port names end up in the URIs of the triples that go in the queryservice
| @@ -1,18 +1,5 @@ | |||
| version: '2' | |||
| services: | |||
|
|
|||
| wikibase: | |||
There was a problem hiding this comment.
I don't really know what these overrides are good for. Containers can use the Docker network (instead of the host one) in both CI and local testing.
| @@ -1,41 +1,52 @@ | |||
| var http = require('http'); | |||
| const wbEdit = require( 'wikibase-edit' )( require( './wikibase-edit.config' ) ); | |||
|
|
|||
| var x = 0 | |||
| http.createServer(async function (req, res) { | |||
| res.writeHead(200, {'Content-Type': 'text/json'}); | |||
There was a problem hiding this comment.
Having this as the first line meant we'd 200 even when wikibase was still down.
| res.end(JSON.stringify([responseObject])); | ||
| return; | ||
| default: | ||
| res.writeHead(404); |
There was a problem hiding this comment.
I like this; good idea to ensure it 404s everywhere else
|
"passes by accident" was badly phrased when I did not understand every detail of this yet. What happens is that the previous tests relied on an intricate choreography of retries and server restarts that stopped working when more requests were made against the failing server. |
Connects #139
The mock api service relies on the
wikibaseservice being up. Currently they are racing, and the mock api keeps crashing because of an unhandled promise rejection untilwikibaseis up.When adding additional logic in #139, this fail-forward approach does not work anymore as the seeding fails to win the race against the retry logic.
This PR does two things: